From 292df678246ca8e7a5c3dcc78249860746a21d0d Mon Sep 17 00:00:00 2001 From: James Lamb Date: Sat, 14 Jan 2023 12:29:25 -0600 Subject: [PATCH] [R] remove unused define XGBOOST_CUSTOMIZE_LOGGER (#8647) --- R-package/src/Makevars.in | 2 +- R-package/src/Makevars.win | 2 +- include/xgboost/base.h | 7 ------- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/R-package/src/Makevars.in b/R-package/src/Makevars.in index 6d9113ed5..e724ebcb7 100644 --- a/R-package/src/Makevars.in +++ b/R-package/src/Makevars.in @@ -7,7 +7,7 @@ CXX_STD = CXX14 XGB_RFLAGS = -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0\ -DDMLC_ENABLE_STD_THREAD=$(ENABLE_STD_THREAD) -DDMLC_DISABLE_STDIN=1\ - -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 + -DDMLC_LOG_CUSTOMIZE=1 # disable the use of thread_local for 32 bit windows: ifeq ($(R_OSTYPE)$(WIN),windows) diff --git a/R-package/src/Makevars.win b/R-package/src/Makevars.win index 1914384e8..ebd7c808c 100644 --- a/R-package/src/Makevars.win +++ b/R-package/src/Makevars.win @@ -7,7 +7,7 @@ CXX_STD = CXX14 XGB_RFLAGS = -DXGBOOST_STRICT_R_MODE=1 -DDMLC_LOG_BEFORE_THROW=0\ -DDMLC_ENABLE_STD_THREAD=$(ENABLE_STD_THREAD) -DDMLC_DISABLE_STDIN=1\ - -DDMLC_LOG_CUSTOMIZE=1 -DXGBOOST_CUSTOMIZE_LOGGER=1 + -DDMLC_LOG_CUSTOMIZE=1 # disable the use of thread_local for 32 bit windows: ifeq ($(R_OSTYPE)$(WIN),windows) diff --git a/include/xgboost/base.h b/include/xgboost/base.h index 34312223c..a1703d610 100644 --- a/include/xgboost/base.h +++ b/include/xgboost/base.h @@ -31,13 +31,6 @@ #define XGBOOST_LOG_WITH_TIME 1 #endif // XGBOOST_LOG_WITH_TIME -/*! - * \brief Whether customize the logger outputs. - */ -#ifndef XGBOOST_CUSTOMIZE_LOGGER -#define XGBOOST_CUSTOMIZE_LOGGER XGBOOST_STRICT_R_MODE -#endif // XGBOOST_CUSTOMIZE_LOGGER - /*! * \brief Whether to customize global PRNG. */