From 1bf4083dc6d632e901e58bf4e8d3fc3c18d96978 Mon Sep 17 00:00:00 2001 From: Nikita Titov Date: Wed, 7 Nov 2018 01:53:33 +0300 Subject: [PATCH] open README with utf-8 and add gcc-8 (#3867) --- python-package/setup.py | 3 ++- python-package/xgboost/build-python.sh | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/python-package/setup.py b/python-package/setup.py index d4b6aa6bc..0c705ee38 100644 --- a/python-package/setup.py +++ b/python-package/setup.py @@ -1,6 +1,7 @@ # pylint: disable=invalid-name, exec-used """Setup xgboost package.""" from __future__ import absolute_import +import io import sys import os from setuptools import setup, find_packages @@ -31,7 +32,7 @@ print("Install libxgboost from: %s" % LIB_PATH) setup(name='xgboost', version=open(os.path.join(CURRENT_DIR, 'xgboost/VERSION')).read().strip(), description="XGBoost Python Package", - long_description=open(os.path.join(CURRENT_DIR, 'README.rst')).read(), + long_description=io.open(os.path.join(CURRENT_DIR, 'README.rst'), encoding='utf-8').read(), install_requires=[ 'numpy', 'scipy', diff --git a/python-package/xgboost/build-python.sh b/python-package/xgboost/build-python.sh index cc426a53c..cdb4fb9ae 100755 --- a/python-package/xgboost/build-python.sh +++ b/python-package/xgboost/build-python.sh @@ -25,6 +25,9 @@ if echo "${OSTYPE}" | grep -q "darwin"; then elif which g++-7; then export CC=gcc-7 export CXX=g++-7 + elif which g++-8; then + export CC=gcc-8 + export CXX=g++-8 elif which clang++; then export CC=clang export CXX=clang++