Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify bound checking in feature interaction constraints (#4428)

Browse Source
This commit is contained in:
Philip Hyunsu Cho 2019-05-01 16:59:53 -07:00 committed by GitHub
parent 4c74336384
commit 17df5fd296
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tree/split_evaluator.cc
View File

@ -515,12 +515,8 @@ class InteractionConstraint final : public SplitEvaluator {
// permissible in a given node; returns false otherwise // permissible in a given node; returns false otherwise
inline bool CheckInteractionConstraint(bst_uint featureid, bst_uint nodeid) const { inline bool CheckInteractionConstraint(bst_uint featureid, bst_uint nodeid) const {
// short-circuit if no constraint is specified // short-circuit if no constraint is specified
if (params_.interaction_constraints.empty()) { return (params_.interaction_constraints.empty()
return true; || int_cont_.at(nodeid).count(featureid) > 0);
}
CHECK_LT(nodeid, int_cont_.size()) << "Invariant violated: nodeid = "
<< nodeid << ", int_cont_.size() = " << int_cont_.size();
return (int_cont_[nodeid].count(featureid) > 0);
} }
}; };