Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[R] Remove stringi dependency (#6109)

Browse Source 
* [R] Fix empty empty tests and a test warnings

* [R] Remove stringi dependency (fix #5905)

* Fix R lint check

* [R] Fix automatic conversion to factor in R < 4.0.0 in xgb.model.dt.tree

* Add `R` Makefile variable

Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu>
This commit is contained in:
Vitalie Spinu
2020-09-12 22:18:08 +02:00
committed by GitHub
parent 07945290a2
commit 1453bee3e7
11 changed files with 30 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
R-package/tests/testthat/test_custom_objective.R
View File

@@ -47,7 +47,7 @@ test_that("custom objective with early stop works", {
bst <- xgb.train(param, dtrain, 10, watchlist)
expect_equal(class(bst), "xgb.Booster")
train_log <- bst$evaluation_log$train_error
expect_true(all(diff(train_log)) <= 0)
expect_true(all(diff(train_log) <= 0))
})
test_that("custom objective using DMatrix attr works", {

3
R-package/tests/testthat/test_gc_safety.R
View File

@@ -9,7 +9,8 @@ test_that("train and prediction when gctorture is on", {
test <- agaricus.test
gctorture(TRUE)
bst <- xgboost(data = train$data, label = train$label, max.depth = 2,
eta = 1, nthread = 2, nrounds = 2, objective = "binary:logistic")
eta = 1, nthread = 2, nrounds = 2, objective = "binary:logistic")
pred <- predict(bst, test$data)
gctorture(FALSE)
expect_length(pred, length(test$label))
})

8
R-package/tests/testthat/test_helpers.R
View File

@@ -335,8 +335,8 @@ test_that("xgb.model.dt.tree and xgb.importance work with a single split model",
})
test_that("xgb.plot.tree works with and without feature names", {
xgb.plot.tree(feature_names = feature.names, model = bst.Tree)
xgb.plot.tree(model = bst.Tree)
expect_silent(xgb.plot.tree(feature_names = feature.names, model = bst.Tree))
expect_silent(xgb.plot.tree(model = bst.Tree))
})
test_that("xgb.plot.multi.trees works with and without feature names", {
@@ -390,8 +390,8 @@ test_that("xgb.plot.shap works", {
})
test_that("xgb.plot.shap.summary works", {
xgb.plot.shap.summary(data = sparse_matrix, model = bst.Tree, top_n = 2)
xgb.ggplot.shap.summary(data = sparse_matrix, model = bst.Tree, top_n = 2)
expect_silent(xgb.plot.shap.summary(data = sparse_matrix, model = bst.Tree, top_n = 2))
expect_silent(xgb.ggplot.shap.summary(data = sparse_matrix, model = bst.Tree, top_n = 2))
})
test_that("check.deprecation works", {