From 104fced9c31eeeb1075b2cea08c4f16f2c993015 Mon Sep 17 00:00:00 2001 From: tqchen Date: Fri, 22 Aug 2014 19:52:43 -0700 Subject: [PATCH] ok --- CHANGES.md | 6 +++--- README.md | 15 +++++++-------- src/README.md | 1 + src/learner/evaluation.h | 1 - 4 files changed, 11 insertions(+), 12 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 1e3b5c67f..2c0c5122f 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,4 +1,4 @@ -Change Log of Versions +Change Log ===== xgboost-0.1 @@ -14,8 +14,8 @@ xgboost-0.2x xgboost-unity ===== * Faster tree construction module - - Allows subsample columns as well during tree construction + - Allows subsample columns during tree construction via ```bst:col_samplebytree=ratio``` * Support for boosting from initial predictions * Experimental version of LambdaRank * Linear booster is now parallelized, using parallel coordinated descent. -* Add [Code Guide](src/README.md) for customizing objective function and +* Add [Code Guide](src/README.md) for customizing objective function and evaluation diff --git a/README.md b/README.md index 7b28e4499..73bcd88d0 100644 --- a/README.md +++ b/README.md @@ -21,14 +21,6 @@ Features * Layout of gradient boosting algorithm to support user defined objective * Python interface, works with numpy and scipy.sparse matrix -Version -====== -* This version is named xgboost-unity, the code has been refactored from 0.2x to be cleaner and more flexibility -* This version of xgboost is not compatible with 0.2x, due to huge amount of changes in code structure - - This means the model and buffer file of previous version can not be loaded in xgboost-unity -* For legacy 0.2x code, refer to [Here](https://github.com/tqchen/xgboost/releases/tag/v0.22) -* Change log in [CHANGES.md](CHANGES.md) - Build ====== * Simply type make @@ -40,3 +32,10 @@ Build - In principle, you can put src/xgboost.cpp and src/io/io.cpp into the project, and build xgboost. - For python module, you need python/xgboost_wrapper.cpp and src/io/io.cpp to build a dll. +Version +====== +* This version is named xgboost-unity, the code has been refactored from 0.2x to be cleaner and more flexibility +* This version of xgboost is not compatible with 0.2x, due to huge amount of changes in code structure + - This means the model and buffer file of previous version can not be loaded in xgboost-unity +* For legacy 0.2x code, refer to [Here](https://github.com/tqchen/xgboost/releases/tag/v0.22) +* Change log in [CHANGES.md](CHANGES.md) diff --git a/src/README.md b/src/README.md index 35d9b08e8..5bfc3722a 100644 --- a/src/README.md +++ b/src/README.md @@ -1,5 +1,6 @@ Coding Guide ====== +This file is intended to be notes about code structure in xgboost Project Logical Layout ======= diff --git a/src/learner/evaluation.h b/src/learner/evaluation.h index 02fb8fdf8..966499965 100644 --- a/src/learner/evaluation.h +++ b/src/learner/evaluation.h @@ -43,7 +43,6 @@ inline IEvaluator* CreateEvaluator(const char *name) { if (!strncmp(name, "ams@", 4)) return new EvalAMS(name); if (!strncmp(name, "pre@", 4)) return new EvalPrecision(name); if (!strncmp(name, "pratio@", 7)) return new EvalPrecisionRatio(name); - if (!strncmp(name, "apratio@", 8)) return new EvalPrecisionRatio(name); if (!strncmp(name, "map", 3)) return new EvalMAP(name); if (!strncmp(name, "ndcg", 3)) return new EvalNDCG(name); utils::Error("unknown evaluation metric type: %s", name);