Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix metric serialization. (#9405)

Browse Source
This commit is contained in:
Jiaming Yuan
2023-07-22 08:39:21 +08:00
committed by GitHub
parent dbd5309b55
commit 0de7c47495
2 changed files with 32 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/learner.cc
View File

@@ -583,8 +583,9 @@ class LearnerConfiguration : public Learner {
auto& objective_fn = learner_parameters["objective"];
obj_->SaveConfig(&objective_fn);
std::vector<Json> metrics(metrics_.size(), Json{Object{}});
std::vector<Json> metrics(metrics_.size());
for (size_t i = 0; i < metrics_.size(); ++i) {
metrics[i] = Object{};
metrics_[i]->SaveConfig(&metrics[i]);
}
learner_parameters["metrics"] = Array(std::move(metrics));
@@ -807,14 +808,13 @@ class LearnerConfiguration : public Learner {
void ConfigureMetrics(Args const& args) {
for (auto const& name : metric_names_) {
auto DupCheck = [&name](std::unique_ptr<Metric> const& m) {
return m->Name() != name;
};
auto DupCheck = [&name](std::unique_ptr<Metric> const& m) { return m->Name() != name; };
if (std::all_of(metrics_.begin(), metrics_.end(), DupCheck)) {
metrics_.emplace_back(std::unique_ptr<Metric>(Metric::Create(name, &ctx_)));
mparam_.contain_eval_metrics = 1;
}
}
for (auto& p_metric : metrics_) {
p_metric->Configure(args);
}