From 0988fb191f6aacde50020b2d5e94c92df2ac4e58 Mon Sep 17 00:00:00 2001 From: Adam Johnston Date: Tue, 26 Jun 2018 16:00:28 -0700 Subject: [PATCH] [jvm-packages] avoid use of Seq.apply in buildGroups (#3413) --- .../scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala b/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala index f8ab10cb3..d2febf61a 100644 --- a/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala +++ b/jvm-packages/xgboost4j-spark/src/main/scala/ml/dmlc/xgboost4j/scala/spark/XGBoost.scala @@ -311,15 +311,15 @@ private object Watches { def buildGroups(groups: Seq[Int]): Seq[Int] = { val output = mutable.ArrayBuffer.empty[Int] var count = 1 - var i = 1 - while (i < groups.length) { - if (groups(i) != groups(i - 1)) { + var lastGroup = groups.head + for (group <- groups.tail) { + if (group != lastGroup) { + lastGroup = group output += count count = 1 } else { count += 1 } - i += 1 } output += count output