From 07945290a20dd05820711dc17cb941d46bf699ba Mon Sep 17 00:00:00 2001 From: Jiaming Yuan Date: Fri, 11 Sep 2020 14:09:44 +0800 Subject: [PATCH] Remove unused RABIT targets. (#6110) * Remove rabit mock. * Remove rabit base. --- CMakeLists.txt | 2 +- rabit/CMakeLists.txt | 6 ++---- rabit/src/engine_base.cc | 13 ------------- 3 files changed, 3 insertions(+), 18 deletions(-) delete mode 100644 rabit/src/engine_base.cc diff --git a/CMakeLists.txt b/CMakeLists.txt index 9a046355d..45992046b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -177,7 +177,7 @@ else() -D_CRT_SECURE_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE) endif (MSVC) endif(RABIT_MOCK) -foreach(lib rabit rabit_base rabit_mock rabit_mock_static) +foreach(lib rabit rabit_mock_static) # Explicitly link dmlc to rabit, so that configured header (build_config.h) # from dmlc is correctly applied to rabit. if (TARGET ${lib}) diff --git a/rabit/CMakeLists.txt b/rabit/CMakeLists.txt index c64bea1dd..59df3ebdd 100644 --- a/rabit/CMakeLists.txt +++ b/rabit/CMakeLists.txt @@ -4,13 +4,11 @@ find_package(Threads REQUIRED) add_library(rabit src/allreduce_base.cc src/allreduce_robust.cc src/engine.cc src/c_api.cc) add_library(rabit_mock_static src/allreduce_base.cc src/allreduce_robust.cc src/engine_mock.cc src/c_api.cc) -add_library(rabit_mock SHARED src/allreduce_base.cc src/allreduce_robust.cc src/engine_mock.cc src/c_api.cc) target_link_libraries(rabit Threads::Threads dmlc) target_link_libraries(rabit_mock_static Threads::Threads dmlc) -target_link_libraries(rabit_mock Threads::Threads dmlc) -set(rabit_libs rabit rabit_mock rabit_mock_static) -set_target_properties(rabit rabit_mock rabit_mock_static +set(rabit_libs rabit rabit_mock_static) +set_target_properties(rabit rabit_mock_static PROPERTIES CXX_STANDARD 14 CXX_STANDARD_REQUIRED ON POSITION_INDEPENDENT_CODE ON) diff --git a/rabit/src/engine_base.cc b/rabit/src/engine_base.cc deleted file mode 100644 index fdf663b0c..000000000 --- a/rabit/src/engine_base.cc +++ /dev/null @@ -1,13 +0,0 @@ -/*! - * Copyright (c) 2014 by Contributors - * \file engine_mock.cc - * \brief this is an engine implementation that will - * insert failures in certain call point, to test if the engine is robust to failure - * \author Tianqi Chen - */ -// define use MOCK, os we will use mock Manager -#define NOMINMAX -#include -// switch engine to AllreduceMock -#define RABIT_USE_BASE -#include "engine.cc"