Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix memory leak in XGDMatrixCreateFromMat_omp() (#3182)

Browse Source 
* Fix memory leak in XGDMatrixCreateFromMat_omp()

This replaces the array allocated by new with a std::vector.

Fixes #3161
This commit is contained in:
Will Storey 2018-03-17 19:03:27 -07:00 committed by Rory Mitchell
parent c85995952f
commit 00d9728e4b
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/c_api/c_api.cc
View File

@ -452,11 +452,8 @@ XGB_DLL int XGDMatrixCreateFromMat_omp(const bst_float* data,
// Check for errors in missing elements // Check for errors in missing elements
// Count elements per row (to avoid otherwise need to copy) // Count elements per row (to avoid otherwise need to copy)
bool nan_missing = common::CheckNAN(missing); bool nan_missing = common::CheckNAN(missing);
int *badnan; std::vector<int> badnan;
badnan = new int[nthread]; badnan.resize(nthread, 0);
for (int i = 0; i < nthread; i++) {
badnan[i] = 0;
}
#pragma omp parallel num_threads(nthread) #pragma omp parallel num_threads(nthread)
{ {