Hendrik/xgboost
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Upgrade clang-tidy on CI. (#5469)

Browse Source 
* Correct all clang-tidy errors.
* Upgrade clang-tidy to 10 on CI.

Co-authored-by: Hyunsu Cho <chohyu01@cs.washington.edu>
This commit is contained in:
Jiaming Yuan
2020-04-05 04:42:29 +08:00
committed by GitHub
parent 30e94ddd04
commit 0012f2ef93
107 changed files with 932 additions and 903 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/objective/aft_obj.cc
View File

@@ -95,11 +95,11 @@ class AFTObj : public ObjFunction {
void SaveConfig(Json* p_out) const override {
auto& out = *p_out;
out["name"] = String("survival:aft");
out["aft_loss_param"] = toJson(param_);
out["aft_loss_param"] = ToJson(param_);
}
void LoadConfig(Json const& in) override {
fromJson(in["aft_loss_param"], &param_);
FromJson(in["aft_loss_param"], &param_);
loss_.reset(new AFTLoss(param_.aft_loss_distribution));
}

4
src/objective/multiclass_obj.cu
View File

@@ -170,11 +170,11 @@ class SoftmaxMultiClassObj : public ObjFunction {
} else {
out["name"] = String("multi:softmax");
}
out["softmax_multiclass_param"] = toJson(param_);
out["softmax_multiclass_param"] = ToJson(param_);
}
void LoadConfig(Json const& in) override {
fromJson(in["softmax_multiclass_param"], &param_);
FromJson(in["softmax_multiclass_param"], &param_);
}
private:

14
src/objective/rank_obj.cu
View File

@@ -552,16 +552,15 @@ class MAPLambdaWeightComputer
const auto *dhits_arr = dhits.data().get();
// Group info on device
const auto &dgroups = segment_label_sorter.GetGroupsSpan();
uint32_t ngroups = segment_label_sorter.GetNumGroups();
auto ComputeItemPrecisionLambda = [=] __device__(uint32_t idx) {
if (unsorted_labels[pred_original_pos[idx]] > 0.0f) {
auto idx_within_group = (idx - dgroups[group_segments[idx]]) + 1;
return MAPStats(static_cast<float>(dhits_arr[idx]) / idx_within_group,
return MAPStats{static_cast<float>(dhits_arr[idx]) / idx_within_group,
static_cast<float>(dhits_arr[idx] - 1) / idx_within_group,
static_cast<float>(dhits_arr[idx] + 1) / idx_within_group,
1.0f);
1.0f};
}
return MAPStats();
return MAPStats{};
}; // NOLINT
thrust::transform(thrust::make_counting_iterator(static_cast<uint32_t>(0)),
@@ -784,14 +783,11 @@ class LambdaRankObj : public ObjFunction {
void SaveConfig(Json* p_out) const override {
auto& out = *p_out;
out["name"] = String(LambdaWeightComputerT::Name());
out["lambda_rank_param"] = Object();
for (auto const& kv : param_.__DICT__()) {
out["lambda_rank_param"][kv.first] = kv.second;
}
out["lambda_rank_param"] = ToJson(param_);
}
void LoadConfig(Json const& in) override {
fromJson(in["lambda_rank_param"], &param_);
FromJson(in["lambda_rank_param"], &param_);
}
private:

12
src/objective/regression_obj.cu
View File

@@ -126,11 +126,11 @@ class RegLossObj : public ObjFunction {
void SaveConfig(Json* p_out) const override {
auto& out = *p_out;
out["name"] = String(Loss::Name());
out["reg_loss_param"] = toJson(param_);
out["reg_loss_param"] = ToJson(param_);
}
void LoadConfig(Json const& in) override {
fromJson(in["reg_loss_param"], &param_);
FromJson(in["reg_loss_param"], &param_);
}
protected:
@@ -253,11 +253,11 @@ class PoissonRegression : public ObjFunction {
void SaveConfig(Json* p_out) const override {
auto& out = *p_out;
out["name"] = String("count:poisson");
out["poisson_regression_param"] = toJson(param_);
out["poisson_regression_param"] = ToJson(param_);
}
void LoadConfig(Json const& in) override {
fromJson(in["poisson_regression_param"], &param_);
FromJson(in["poisson_regression_param"], &param_);
}
private:
@@ -546,10 +546,10 @@ class TweedieRegression : public ObjFunction {
void SaveConfig(Json* p_out) const override {
auto& out = *p_out;
out["name"] = String("reg:tweedie");
out["tweedie_regression_param"] = toJson(param_);
out["tweedie_regression_param"] = ToJson(param_);
}
void LoadConfig(Json const& in) override {
fromJson(in["tweedie_regression_param"], &param_);
FromJson(in["tweedie_regression_param"], &param_);
}
private: